Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that LCIO target is also available downstream #59

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Aug 22, 2024

BEGINRELEASENOTES

ENDRELEASENOTES

Otherwise some packages, e.g. KiTrack will not build / link for me.

@jmcarcell
Copy link
Contributor

jmcarcell commented Aug 22, 2024

We can also not use Marlin_LIBRARIES which I would prefer even if it's more work since what's happening now is that some packages are linking a lot of stuff that they don't need, like KiTrack which doesn't need LCIO. See iLCSoft/KiTrack#3 for example. It's three more repositories with a similar change, I can have a look.

@tmadlener
Copy link
Contributor Author

I agree whit cleaning up the downstream consumers. However, I also think that we still need to properly propagate the fact, that Marlin depends on LCIO. So we need both IMHO.

@jmcarcell
Copy link
Contributor

With the four PRs that appear at the bottom of #56 I can build the stack and some missing dependencies are uncovered.

@jmcarcell
Copy link
Contributor

I agree whit cleaning up the downstream consumers. However, I also think that we still need to properly propagate the fact, that Marlin depends on LCIO. So we need both IMHO.

Then I think the target LCIO::lcio shouldn't be created, otherwise cases like KiTrack can't be discovered. And since this is a change being made now I don't think we should worry about older versions of LCIO that would need the LCIO::lcio target.

@tmadlener
Copy link
Contributor Author

If we don't bootstrap the targets in the MarlinConfig.cmake we have to bump the minimum required version of LCIO that is necessary to build Marlin. Otherwise, this will not be fully transparent.

@tmadlener
Copy link
Contributor Author

Should we merge this still today (or revert #56) to avoid breaking the nightlies?

@jmcarcell
Copy link
Contributor

Let's merge this today

@tmadlener tmadlener merged commit b285cce into master Aug 22, 2024
7 checks passed
@tmadlener tmadlener deleted the proper-lcio-dep branch August 22, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants